Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tabs navigation on the settings page #4289

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Fix tabs navigation on the settings page #4289

merged 4 commits into from
Apr 30, 2024

Conversation

maskin25
Copy link
Contributor

@maskin25 maskin25 commented Apr 26, 2024 •
edited

What this PR does

Fix tabs navigation on the settings page

Which issue(s) this PR closes

Related to https://github.com/grafana/oncall-private/issues/2563

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@maskin25 maskin25 added pr:no public docs Added to a PR that does not require public documentation updates release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes labels Apr 26, 2024
@maskin25 maskin25 self-assigned this Apr 26, 2024
@maskin25 maskin25 requested a review from a team as a code owner April 26, 2024 13:18
joeyorlando
joeyorlando approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe consider adding a test for this?

@brojd brojd self-requested a review April 30, 2024 10:55
brojd
brojd approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@brojd brojd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to improve the locator in e2e test but it's not a blocker. Looks good in general

@maskin25 @brojd
Update grafana-plugin/e2e-tests/settings/tabs.test.ts
cb8a621 
Co-authored-by: Dominik Broj <dominik.broj@grafana.com>
@maskin25 maskin25 enabled auto-merge April 30, 2024 13:23
@maskin25 maskin25 added this pull request to the merge queue Apr 30, 2024
Merged via the queue into dev with commit 2f1ea7d Apr 30, 2024
21 checks passed
@maskin25 maskin25 deleted the maxim/fix-setting-tabs-query-params branch April 30, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

@brojd brojd brojd approved these changes

Assignees

@maskin25 maskin25

Labels
pr:no public docs Added to a PR that does not require public documentation updates release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maskin25 @joeyorlando @brojd