-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show info about missing users in schedules #4294
Conversation
font-weight: 500; | ||
pointer-events: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one blocked showing tooltip within schedule slot, it was added long time ago and as far as I tested, everything works without it. But if you remember some context about it @maskin25 , pls let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I haven't seen any issues with tooltip over schedule slot, and tooltip is attached to a higher level container, not to the title element. I forgot the reason of adding pointer-events: none
here, I'm almost sure there was some reason but probably it doesn't make sense anymore after several iterations with schedules and visual components rearranging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!
<HorizontalGroup justify={justify}> | ||
<span>Missing user</span> | ||
<Tooltip | ||
content={<>{`${userName || 'User'} `} is not found or doesn't have permission to participate in the rotation</>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor
it could be just a string without using Fragment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thanks
…na/oncall into brojd/fix-user-not-found-in-shifts
What this PR does
Which issue(s) this PR closes
Closes #4251
Checklist
pr:no public docs
PR label added if not required)release:
). These labels dictate how your PR willshow up in the autogenerated release notes.