Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging of arguments for celery tasks #4314

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented May 6, 2024

What this PR does

Enables logging of arguments for celery tasks. Currently it can be difficult to troubleshoot issues as many tasks give no context to what they are operating on in the logs.

Which issue(s) this PR closes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@mderynck mderynck changed the title Log arguments for celery tasks Add loggin of arguments for celery tasks May 6, 2024
@mderynck mderynck changed the title Add loggin of arguments for celery tasks Add logging of arguments for celery tasks May 6, 2024
@mderynck mderynck added release:patch PR will be added to "Other Changes" section of release notes pr:no public docs Added to a PR that does not require public documentation updates labels May 6, 2024
@mderynck mderynck marked this pull request as ready for review May 6, 2024 20:54
@mderynck mderynck requested a review from a team as a code owner May 6, 2024 20:54
@mderynck mderynck added this pull request to the merge queue May 6, 2024
Merged via the queue into dev with commit 477477e May 6, 2024
21 checks passed
@mderynck mderynck deleted the mderynck/celery-logging branch May 6, 2024 22:02
@mderynck mderynck mentioned this pull request May 7, 2024
3 tasks
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
# What this PR does
Follow-up to #4314. Remove kwargs from celery logging as it included
more information than needed.

## Which issue(s) this PR closes

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants