Upgrade sdk and use latest grafana UI #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderzobnin
approved these changes
Mar 30, 2021
sunker
commented
Mar 30, 2021
package.json
Outdated
| "@grafana/data": "7.5.0-pre.0-f0d6f132ae", | ||
| "@grafana/runtime": "7.5.0-pre.0-f0d6f132ae", | ||
| "@grafana/toolkit": "7.5.0-pre.0-f0d6f132ae", | ||
| "@grafana/ui": "7.5.0-pre.0-f0d6f132ae", |
There was a problem hiding this comment.
7.5.0-pre.0-x are pre-releases. If you get a 401 when running yarn, follow this instruction.
However, the pre-releases are just for testing. As soon as grafana 7.5.2 is released, we should point to those instead. @grafana/aws-sdk should be using 0.0.3.
| } from '@grafana/data'; | ||
| import LanguageProvider from './language_provider'; | ||
| import { ElasticResponse } from './elastic_response'; | ||
| import { IndexPattern, getDefaultTimeRange } from './index_pattern'; | ||
| import { ElasticQueryBuilder } from './query_builder'; | ||
| import { toUtc } from '@grafana/data'; |
There was a problem hiding this comment.
got a build error so refactored this. please verify is looks ok
| @@ -2,6 +2,7 @@ import { DataSourceSettings } from '@grafana/data'; | |||
|
|
|||
| export function createDatasourceSettings<T>(jsonData: T): DataSourceSettings<T> { | |||
| return { | |||
| typeName: '', | |||
There was a problem hiding this comment.
consequence of grafana/data update a think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This text is copied from this pr in grafana
What this PR does / why we need it:
This PR upgrades the golang sigv4 package. The new version of the package has support for:
It also replaces the custom SigV4 react component that was rendered in DataSourceHttpSettings with the ConnectionConfig from the @grafana/aws-sdk npm package. The ConnectionConfig component is already being used as ConfigEditor for CloudWatch, IoT Sitewise, Timestream and the X-ray plugin.
The changes in the @grafana/aws-sdk has been kept to a minimum since it's already been tested and is used by other plugins. A few minor things have been added though:
**Special notes for your review
Do not merge before grafana 7.5.2 is released and the pre-released for grafana packages are replaced by real version numbers from npm