-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate readme from Elasticsearch plugin #19
Conversation
Add Elasticsearch docs with minor modifications for plugin name, feature list, PPL
Image links haven't been updated yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One detail: we have 2 readme files right now, one in the repo root and the other one in the src/
folder. Grafana use readme from src/ if it exists, so if we update the root readme, please, delete src/README.md
, otherwise information that user will see in Grafana won't be updated.
This Elasticsearch templated dashboard is linked from the docs. @alexanderzobnin would we expect this to work the same way for ODFE, or should we consider creating a new templated dashboard example for ODFE? Another option would be simply to remove this line from the docs for now, since it is just a nice-to-have. |
Okay, I think this is ready for review. @anirudha I'd appreciate your feedback on the accuracy here, especially in the auth sections. @alexanderzobnin are all of these screenshots still accurate? This should basically be just the same as the Elastic plugin, with the names changed, links updated, and a little snippet for PPL. |
Add Elasticsearch docs with minor modifications for plugin name, feature list, PPL.