Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frontend tests #7

Merged
merged 6 commits into from
Dec 21, 2020
Merged

Fix frontend tests #7

merged 6 commits into from
Dec 21, 2020

Conversation

alexanderzobnin
Copy link
Contributor

@alexanderzobnin alexanderzobnin commented Dec 16, 2020 •
edited

This is PR contains fixes for failing tests.

@alexanderzobnin alexanderzobnin marked this pull request as ready for review December 17, 2020 10:55
@alexanderzobnin alexanderzobnin changed the title Fix tests WIP Fix frontend tests Dec 17, 2020
ahlaw
ahlaw approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@ahlaw ahlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

euniceek
euniceek approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@euniceek euniceek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexanderzobnin alexanderzobnin merged commit a12780e into master Dec 21, 2020
@Elfo404 Elfo404 deleted the fix-tests branch April 14, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahlaw ahlaw ahlaw approved these changes

@euniceek euniceek euniceek approved these changes

@Elfo404 Elfo404 Awaiting requested review from Elfo404

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexanderzobnin @ahlaw @euniceek