Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS authentication information in devenv readme #115

Merged
merged 5 commits into from
Apr 10, 2023
Merged

Conversation

fridgepoet
Copy link
Member

@fridgepoet fridgepoet commented Mar 29, 2023

What this PR does / why we need it:
This adds instructions to the devenv README for how to set up TLS authentication. This will be useful for testing the changes in #118

@github-actions
Copy link

Backend code coverage report for PR #115
No changes

@github-actions
Copy link

Frontend code coverage report for PR #115
No changes

@github-actions
Copy link

github-actions bot commented Mar 29, 2023

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7...
✔ Found @grafana/data version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7...
✔ Found @grafana/ui version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7...
✔ Found @grafana/runtime version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7...
✔ Found @grafana/e2e-selectors version 9.0.2 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

1 similar comment
@github-actions
Copy link

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7...
✔ Found @grafana/data version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7...
✔ Found @grafana/ui version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7...
✔ Found @grafana/runtime version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7...
✔ Found @grafana/e2e-selectors version 9.0.2 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@fridgepoet fridgepoet marked this pull request as ready for review March 30, 2023 09:53
@fridgepoet fridgepoet requested a review from a team as a code owner March 30, 2023 09:53
@fridgepoet fridgepoet requested review from idastambuk and kevinwcyu and removed request for a team March 30, 2023 09:53
@idastambuk
Copy link
Contributor

I followed the instructions, but after clicking Save & Test in the datasource configuration, I got "No date field named @timestamp found"What worked was:

  1. go to https://localhost:5601/ and generate sample data
  2. Change @timestamp to timestamp in the config editor
    as @fridgepoet suggested.

Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, instructions worked for me.

@fridgepoet fridgepoet merged commit 6c70156 into main Apr 10, 2023
@fridgepoet fridgepoet deleted the contributing branch April 10, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants