Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Use time range' option, skip date type field validation #125

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

z0h3
Copy link
Contributor

@z0h3 z0h3 commented Apr 5, 2023

What this PR does / why we need it:

  1. When we have many indices in elasticsearch with different names of date type (not universally @timestamp) field.
  2. In some cases we have indices that doesn't contain any date type field.

We can't search data for this cases.

Which issue(s) this PR fixes:

  1. This PR allows to skip validation for date field, and doesn't block adding new datasource.
    image

  2. This PR also adds switch option Use time range for raw_data and raw_document search type. This option includes/excludes time range filter and sort in query request for raw_data and raw_document types only. Default value is enabled.
    image

@z0h3 z0h3 requested a review from a team as a code owner April 5, 2023 08:46
@z0h3 z0h3 requested review from iwysiu and sarahzinger and removed request for a team April 5, 2023 08:46
@CLAassistant
Copy link

CLAassistant commented Apr 5, 2023

CLA assistant check
All committers have signed the CLA.

@sarahzinger
Copy link
Member

@z0h3 thank you so much for your contribution! This is a great suggestion! Would you mind signing our CLA? Just follow the link in the above comment.

@z0h3 z0h3 force-pushed the optional-timerange-and-index branch from d60c08c to bba7c78 Compare April 6, 2023 08:47
@z0h3 z0h3 force-pushed the optional-timerange-and-index branch from bba7c78 to a6808b9 Compare April 6, 2023 09:02
@z0h3
Copy link
Contributor Author

z0h3 commented Apr 6, 2023

@sarahzinger Done!

Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Thank you so much!

@sarahzinger sarahzinger merged commit 67aaa01 into grafana:main Apr 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants