Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Traces Query Editor #127

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Tests for Traces Query Editor #127

merged 4 commits into from
Apr 6, 2023

Conversation

sarahzinger
Copy link
Member

Based on a work in progress branch: #122

Adds some basic tests for our work in progress branch to support Trace Analytics:

  • tests the new top level query editor
  • tests the new traces query editor which sets the query to be for either a single query or a traces view list query

Once this is merged I think we can close #107

@sarahzinger sarahzinger marked this pull request as ready for review April 5, 2023 20:38
@sarahzinger sarahzinger requested a review from a team as a code owner April 5, 2023 20:38
@sarahzinger sarahzinger requested review from iwysiu and idastambuk and removed request for a team April 5, 2023 20:38
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7...
✔ Found @grafana/data version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7...
✔ Found @grafana/ui version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7...
✔ Found @grafana/runtime version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7...
✔ Found @grafana/e2e-selectors version 9.0.2 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Backend code coverage report for PR #127
No changes

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Frontend code coverage report for PR #127

Plugin Main PR Difference
src 76.88% 76.18% -.70%

@sarahzinger sarahzinger merged commit f22d4c6 into traces-query-editor Apr 6, 2023
3 checks passed
@sarahzinger sarahzinger deleted the traces-query-editor-tests branch April 6, 2023 12:39
sarahzinger added a commit that referenced this pull request Apr 6, 2023
@sarahzinger
Tests for Traces Query Editor (#127)
d6ed66e 
* Test for LuceneQueryEditor
sarahzinger added a commit that referenced this pull request Apr 19, 2023
@sarahzinger
Tests for Traces Query Editor (#127)
8792ce8 
* Test for LuceneQueryEditor
idastambuk pushed a commit that referenced this pull request May 2, 2023
@sarahzinger @idastambuk
Tests for Traces Query Editor (#127)
ccd832c 
* Test for LuceneQueryEditor
idastambuk pushed a commit that referenced this pull request May 11, 2023
@sarahzinger @idastambuk
Tests for Traces Query Editor (#127)
77214a0 
* Test for LuceneQueryEditor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idastambuk idastambuk idastambuk approved these changes

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu was automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sarahzinger @idastambuk