Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

137 trace analytics hide alias #139

Merged
merged 5 commits into from
Apr 18, 2023
Merged

137 trace analytics hide alias #139

merged 5 commits into from
Apr 18, 2023

Conversation

idastambuk
Copy link
Contributor

@idastambuk idastambuk commented Apr 17, 2023 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #137

Special notes for your reviewer:

@idastambuk idastambuk requested a review from a team as a code owner April 17, 2023 13:03
@idastambuk idastambuk requested review from fridgepoet, iwysiu and sarahzinger and removed request for a team, fridgepoet and iwysiu April 17, 2023 13:03
@github-actions
Copy link

Backend code coverage report for PR #139
No changes

@github-actions
Copy link

github-actions bot commented Apr 17, 2023 •
edited

Frontend code coverage report for PR #139

Plugin Main PR Difference
src 76.89% 77.77% .88%

@github-actions
Copy link

github-actions bot commented Apr 17, 2023 •
edited

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7...
✔ Found @grafana/data version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7...
✔ Found @grafana/ui version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7...
✔ Found @grafana/runtime version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7...
✔ Found @grafana/e2e-selectors version 9.0.2 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

sarahzinger
sarahzinger approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Might be nice to add a test if we can and also link the original issue to the pr!

@idastambuk idastambuk merged commit 5fc6546 into traces-query-editor Apr 18, 2023
3 checks passed
@idastambuk idastambuk deleted the 137-trace-analytics-hide-alias branch April 18, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idastambuk @sarahzinger