Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fridgepoet to cspell list #146

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Add fridgepoet to cspell list #146

merged 1 commit into from
Apr 19, 2023

Conversation

iwysiu
Copy link
Contributor

@iwysiu iwysiu commented Apr 18, 2023

Fix the failing spell-check test.

@github-actions
Copy link

Backend code coverage report for PR #146
No changes

@github-actions
Copy link

Frontend code coverage report for PR #146
No changes

@iwysiu iwysiu marked this pull request as ready for review April 18, 2023 21:24
@iwysiu iwysiu requested a review from a team as a code owner April 18, 2023 21:24
@iwysiu iwysiu requested review from fridgepoet and idastambuk and removed request for a team April 18, 2023 21:24
@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7...
✔ Found @grafana/data version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7...
✔ Found @grafana/ui version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7...
✔ Found @grafana/runtime version 9.0.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7...
✔ Found @grafana/e2e-selectors version 9.0.2 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@fridgepoet
Copy link
Member

Oops! Should we require CI to pass in order to merge?

@fridgepoet
Copy link
Member

We can update the branch protection rule on main to require continuous-integration/drone/pr to pass before merging.

@iwysiu iwysiu merged commit fe5b0d3 into main Apr 19, 2023
3 checks passed
@iwysiu iwysiu deleted the fix-spellcheck branch April 19, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridgepoet fridgepoet fridgepoet approved these changes

@idastambuk idastambuk idastambuk approved these changes

@kevinwcyu kevinwcyu kevinwcyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iwysiu @fridgepoet @idastambuk @kevinwcyu