Ability to select order (Desc/Asc) for "raw data" metrics aggregations #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
matyax
changed the title
gabor
requested review from
a team,
fridgepoet and
iwysiu
and removed request for
a team
|
@lvta0909 sorry for the delay in reviewing, this looks really good to me! I merged in master and made some minor changes if you'd like to take a look! |
|
@iwysiu mind reviewing this since I added a few more commits? I can merge/release once you think it looks good. |
|
Also I believe the build is failing because the levity check fails for all external contributors right now. |
iwysiu
reviewed
May 18, 2023
| const newOrderValue = 'asc'; | ||
| await userEvent.click(screen.getByText('Ascending')); | ||
| expect(onChange).toHaveBeenCalledTimes(2); | ||
| // expect(onChange).toHaveBeenCalledWith(expect.objectContaining({'order' : 'asc'})); |
There was a problem hiding this comment.
should this be removed/uncommented?
| @@ -28,6 +28,8 @@ interface Props { | |||
| previousMetrics: MetricAggregation[]; | |||
| } | |||
|
|
|||
| const orderLabel = 'Test Order select Container'; | |||
There was a problem hiding this comment.
I don't think this needs to be a separate variable
There was a problem hiding this comment.
Removed this altogether, since afaik InlineField doesn't need an explicit arial-label
idastambuk
reviewed
May 21, 2023
| @@ -256,3 +258,9 @@ export const getChildren = (metric: MetricAggregation, metrics: MetricAggregatio | |||
|
|
|||
| return [...children, ...children.flatMap(child => getChildren(child, metrics))]; | |||
| }; | |||
|
|
|||
| // TODO: Define better types for the following | |||
| export const orderOptions = [ | |||
There was a problem hiding this comment.
Suggested change
| export const orderOptions = [ | |
| export const orderOptions: Array<SelectableValue<string>> = [ |
iwysiu
approved these changes
May 23, 2023
Merged
fridgepoet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add ability to select the query order for "raw data" metric agreggation.
Why?
Sometimes it is needed to query the firsts X documents starting from a defined time. With the default query order as Descending it was not directly possible as it would give the lasts X documents from the ending time.
The ability to choose the order solves this limitation.
This functionality is available only to "raw data" and "raw document" metric queries.