-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add access policies for OpenSearch Service and OpenSearch Serverless #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Should we make a comment you think to say Open Search Serverless should be supported in Grafana 9.4 and above? cc @svennergr @gabor
@sarahzinger wrote:
good idea! hmm.. though..the question is, what should we say in the required-grafana-version setting in plugin.json : https://github.com/grafana/opensearch-datasource/blob/main/src/plugin.json#L30 ? possibilities:
what do you think? |
I'm leaning towards keeping the required grafana version as-is because the opensearch-service part should still work for older versions and people who actively want to use opensearch-serverless will have to make the decision to upgrade grafana or not. Also looks like opensearch serverless was only recently released, so probably not many people using it just yet. So it seems like it would be lower friction for existing opensearch-service users if we leave the required version as-is for the moment. |
@gabor I'm trying to tag the docs squad to review this, but they don't show up in reviewers dropdown for me. I think they need to be added as collaborators on this repo to show up in the reviewers dropdown. Would you be able to add them please? |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Docs squad] LGTM
This PR documents the minimal set of permissions required to use the opensearch datasource with OpenSearch Service and OpenSearch Serverless.
Fixes: #96
Changes:
Elasticsearch Service
toOpenSearch Service
Notes to reviewer:
I tested these permissions the default query for the datasource. I don't know if there are other permissions required depending on the query or some other settings.
References: