Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #98)
when using the
moving_avg
metric, for certain modes there are coefficients (alpha
,beta
,gamma
) that can be configured. the code usedparseInt
to parse them, so when floating-point values are entered (for example0.35
), it was parsed incorrectly).also the
MovingAverageEWMAModelSettings
type was defined incorrectly.how to test:
moving_avg
. configure it:field
: choosecount
options
, choosemodel=holt-winters
alpha
beta
andgamma
are floating-point values, not integers_msearch
)'s request-payload, it contains two lines of json, the second json should contain the correctalpha
,beta
andgamma
values.exponentially weighted
, and repeat the testholt linear
, and repeat the testalpha
,beta
andgamma
contain the correct values after a page reload. test all 3 models (holt-winters
,holt-linear
,exponentially-weighted
)