Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto-update script to handle new go modules from core #40

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

rlankfo
Copy link
Member

@rlankfo rlankfo commented Jan 21, 2023

Signed-off-by: Robbie Lankford robert.lankford@grafana.com

@jpkrohling I saw your comment on #37 and updated the script. Feel free to close if this isn't what you had in mind.

Signed-off-by: Robbie Lankford <robert.lankford@grafana.com>
Copy link
Collaborator

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks about right! Thanks!

@jpkrohling jpkrohling merged commit 03d26b8 into main Jan 23, 2023
@jpkrohling jpkrohling deleted the auto-update-script branch January 23, 2023 12:30
@jpkrohling
Copy link
Collaborator

I've seen a failure when running the workflow manually, but it's likely unrelated to this PR:

jq: error: Could not open file latest-core.json: No such file or directory
date: invalid date ‘+%s’
jq: error: Could not open file latest-contrib.json: No such file or directory
date: invalid date ‘+%s’
./scripts/update-to-latest-otelcol.sh: line 48: ((: <  : syntax error: operand expected (error token is "<  ")

@rlankfo
Copy link
Member Author

rlankfo commented Jan 23, 2023

Are you on a mac? Running it locally on mac I had to make sure to use GNU date or I had the same error.

@jpkrohling
Copy link
Collaborator

jpkrohling commented Jan 23, 2023

@rlankfo
Copy link
Member Author

rlankfo commented Jan 23, 2023

Ahh this might be a different error than I saw locally but now I'm curious, I'll look into it a bit later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants