Release on changes to main #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
rlankfo
reviewed
Feb 7, 2023
| push: | ||
| tags: ["v*"] |
There was a problem hiding this comment.
I assume we'll still want to run the release workflow on tag as well?
There was a problem hiding this comment.
Not sure -- tags are just annotations on existing commits. If we don't plan on tagging commits that exist only on specific branches, we should be fine. If we want to have tags, and if we want a special build for that, we can trigger it manually after pushing the tag. git describe should then return the proper version based on the tag.
There was a problem hiding this comment.
Created #50 to discuss
rlankfo
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de