Add tests #5
Merged
Add tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
force-pushed
the
jpkrohling/issue1
branch
from
741f5d5
to
cbd446f
Compare
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
|
@gouthamve, could you please take a look at this one? I'm accepting suggestions to replace the bash code. |
|
@fstab, if you'd like to review this one as well, it would be much appreciated! |
|
@fstab, should I continue pursuing this? |
|
Merging, as we can change it later if this doesn't fit our needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for all current distributions.
Requires #4 and closes #1