Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use timeout keyword in force_flush + shutdown #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wesleygraybill
Copy link

@wesleygraybill wesleygraybill commented Mar 5, 2024

The original implementation does not conform to the interface required by OpenTel (documentation). This results in errors during span shutdown unknown keyword: :timeout (ArgumentError). Additionally, the spec specifies that an integer should be returned, 0 for success.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants