Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support opentelemetry-api 1.2.x #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support opentelemetry-api 1.2.x #8

wants to merge 1 commit into from

Conversation

BrianHawley
Copy link

  • Change requirement to "~> 1.1" to support both versions.
  • Remove Gemfile.lock from the tracked files. Gem repos should exclude Gemfile.lock because if you don't, you will miss issues that come with new updates in your dependencies.
  • Ignore .ruby-version and .ruby-gemset to support local development and testing.

Fixes #7

@BrianHawley
Support opentelemetry-api 1.2.x
7b3d6a5 
- Change requirement to "~> 1.1" to support both versions.
- Remove Gemfile.lock from the tracked files. Gem repos should exclude
  Gemfile.lock because if you don't, you will miss issues that come with
  new updates in your dependencies.
- Ignore .ruby-version and .ruby-gemset to support local development and
  testing.

Fixes grafana#7
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@BrianHawley
Copy link
Author

@korniltsev could you review this?

@BrianHawley
Copy link
Author

@korniltsev who merges PRs? It would be good to get this in.

@korniltsev
Copy link
Collaborator

I can merge but I wanted to test it by running both versions before merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korniltsev korniltsev korniltsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support opentelemetry-api 1.2.x
3 participants
@BrianHawley @CLAassistant @korniltsev