This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
implicitly detect secret types and set field accordingly #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trotttrotttrott
approved these changes
Apr 22, 2020
| } | ||
|
|
||
| // same with .dockerconfigson | ||
| if k8sSecretData[v1.DockerConfigJsonKey] != nil { |
There was a problem hiding this comment.
Why not else if or swich/case?
There was a problem hiding this comment.
I started with that, and then started thinking about priority ordering, and both ways have opposite concerns. If/Else also doesn't solve the case when you have both fields. One is going to win unless we explicitly looks for that (not worth it).
I took it out of the else mostly so the comments lined up, and I thought it was a little more aesthetically pleasing. If you feel strongly one way or another I can change it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simply assumes the type of the secret based on the fields present. Needs no additional config to work.
Note: Updating a secret that already exists of the wrong type will fail. It must be manually destroyed and re-created. This is expected.