This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Allow keeping annotations on synced secrets #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that FluxCD uses the same secret for its SSH key (synced by Pentagon) and for keeping it's state Flux writes an annotation to know where it last ran and then Pentagon wipes it on its regular sync This PR adds the `keepAnnotations` setting for mappings. (I also did `keepLabels` for consistency, it's the same)
|
I don't seem to have proper review permissions (maybe that could be fixed? 🙏) but 👍. It's right that this should be at the per-mapping level. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that FluxCD uses the same secret for its SSH key (synced by Pentagon) and for keeping it's state
Flux writes an annotation to know where it last ran and then Pentagon wipes it on its regular sync
This PR adds the
keepAnnotationssetting for mappings. (I also didkeepLabelsfor consistency, it's the same)