Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Top table visualization #171

Closed
Tracked by #169
cyriltovena opened this issue Aug 26, 2022 · 1 comment · Fixed by #255
Closed
Tracked by #169

Top table visualization #171

cyriltovena opened this issue Aug 26, 2022 · 1 comment · Fixed by #255
Assignees
Milestone

Comments

@cyriltovena
Copy link
Collaborator

cyriltovena commented Aug 26, 2022

Top tables are an important part of profile visualisation, We should definitively add a way to open a persistent drawer to see the top symbols by ordered by top %self or %total.

Related backend work #172

We should to always keep full visibility if possible of the flamegraph by resizing it this way we can select top table symbols and highlight the flamegraph. In the case resizing the flamegraph is not possible if the screen is too small then replacing the visualisation will be done.

Example from Pyroscope

image

@cyriltovena cyriltovena changed the title Open as a right slider the top table. Open as a right slider/drawer the top table. Aug 26, 2022
@cyriltovena cyriltovena added this to the mvp-launch-obscon milestone Aug 26, 2022
@cyriltovena cyriltovena changed the title Open as a right slider/drawer the top table. The top table visualisation Aug 26, 2022
@cyriltovena cyriltovena changed the title The top table visualisation Top table visualisation Aug 26, 2022
@cyriltovena cyriltovena changed the title Top table visualisation Top table visualization Aug 26, 2022
@evandandrea
Copy link

Agreement in the weekly call that the "top table" will be part of the flame graph panel (so you can always see side-by-side regardless of screen size).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants