Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm ingress doesn't support pyroscope ingress #2062

Closed
simonswine opened this issue May 12, 2023 · 2 comments · Fixed by #2807
Closed

Helm ingress doesn't support pyroscope ingress #2062

simonswine opened this issue May 12, 2023 · 2 comments · Fixed by #2807

Comments

@simonswine
Copy link
Contributor

No description provided.

@simonswine simonswine transferred this issue from grafana/phlare Jul 19, 2023
@macmiranda
Copy link

Hi @simonswine, do you mean that the Ingress object created by Helm will not support the Pyroscope UI?

I haven't tried it myself but looking at the templates, it does seem like it. I have created an Ingress manually with Prefix / and it works fine.

Is that what you have in mind?

@rlex
Copy link
Contributor

rlex commented Nov 19, 2023

Ingress seemingly only supports certain paths, but not root, so webui is not accessible from ingress.

Fix is simple, just add

          - path: /
            pathType: Prefix
            backend:
              service:
                name: pyroscope
                port:
                  number: 4040

to list of paths under ingress somewhere here: https://github.com/grafana/pyroscope/blob/main/operations/pyroscope/helm/pyroscope/templates/ingress.yaml#L25

Should i shoot a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants