Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ingress for pyroscope UI #2807

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix ingress for pyroscope UI #2807

merged 1 commit into from
Dec 7, 2023

Conversation

rlex
Copy link
Contributor

@rlex rlex commented Dec 5, 2023

Closes #2062 - adding root path for ingress, allowing opening pyroscope UI with ingress

@rlex rlex requested a review from a team as a code owner December 5, 2023 23:45
@cyriltovena
Copy link
Contributor

Thanks ! I think you'll need to run make helm/lint and make helm/check

@rlex
Copy link
Contributor Author

rlex commented Dec 6, 2023

Nothing changed after run, since i hasn't touched variables and syntax seems to be ok from the start

cyriltovena
cyriltovena approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sorry I didn't realize ingress is not on by default !

@cyriltovena cyriltovena merged commit d8f8194 into grafana:main Dec 7, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm ingress doesn't support pyroscope ingress
2 participants
@rlex @cyriltovena