This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Datasource: Implement the query API #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aocenas
commented
Aug 10, 2022
| Label(): string { | ||
| return this.name + " - " + this.sampleType; | ||
| } | ||
| export interface ProfileTypeMessage { |
There was a problem hiding this comment.
I changed this to just use the message from the back end instead of packaging into data object. There does not seem that much benefit right now.
aocenas
commented
Aug 10, 2022
|
|
||
| type Props = QueryEditorProps<DataSource, Query, MyDataSourceOptions>; | ||
|
|
||
| export function QueryEditor(props: Props) { | ||
| const [profileTypes, setProfileTypes] = useState<CascaderOption[]>([]); | ||
| const [profileTypes, setProfileTypes] = useState<ProfileTypeMessage[]>([]); |
There was a problem hiding this comment.
Cascader option are generated from this later on. Having this in raw messages makes it easier to search through them.
aocenas
commented
Aug 10, 2022
| LabelSelector: string; | ||
| ProfileType?: ProfileType; | ||
| labelSelector: string; | ||
| profileTypeId: string; |
There was a problem hiding this comment.
Sending just the ID seems a bit more sensible than the while type, and backend only requires the ID anyway.
This was referenced Aug 11, 2022
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Datasource: Implement the query API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic code to get a request from the front end, send a request to Fire and then parse and package into DataFrame and send back.
The format of the data frame is a bit simple as the data for the profile does not match our dataFrame structure that well and in the future that may be changed.