Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Remove unused import and fix typo #668

Merged
merged 3 commits into from May 9, 2023
Merged

Remove unused import and fix typo #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfcf1c3
Remove unused import and fix typo
hi-rustin May 5, 2023
639ff90
All use yml
hi-rustin May 5, 2023
70352f5
Rename
hi-rustin May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
0 .github/workflows/frontend.yaml → .github/workflows/frontend.yml
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions public/app/app.tsx
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@ import React from 'react';
import ReactDOM from 'react-dom/client';
import './jquery-import';
import { Provider } from 'react-redux';
import store, { persistor } from './redux/store';
import store from './redux/store';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but doesn't prevent catching the same issue again. Would you mind adding a linter rule to check for unused imports?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to use ESlint? I am glad to add it. I will open a new pull request to introduce the ESlint as the linter.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an issue here #672

import '@webapp/../sass/profile.scss';
import '@szhsin/react-menu/dist/index.css';
import Notifications from '@webapp/ui/Notifications';
Expand Down Expand Up @@ -31,7 +31,7 @@ function App() {
<div className="pyroscope-app">
<LoadAppNames>
<Switch>
<Route exact path={ROUTES.CONTINOUS_SINGLE_VIEW}>
<Route exact path={ROUTES.SINGLE_VIEW}>
<SingleView />
</Route>
<Route path={ROUTES.COMPARISON_VIEW}>
Expand Down
4 changes: 2 additions & 2 deletions public/app/components/Sidebar.tsx
View file
Open in desktop
Expand Up @@ -60,13 +60,13 @@ export function Sidebar() {
<SidebarContent>
<Menu iconShape="square" popperArrow>
<MenuItem
active={isRouteActive(pathname, ROUTES.CONTINOUS_SINGLE_VIEW)}
active={isRouteActive(pathname, ROUTES.SINGLE_VIEW)}
icon={<Icon icon={faWindowMaximize} />}
>
Single View
<NavLink
activeClassName="active-route"
to={{ pathname: ROUTES.CONTINOUS_SINGLE_VIEW, search }}
to={{ pathname: ROUTES.SINGLE_VIEW, search }}
exact
/>
</MenuItem>
Expand Down
2 changes: 1 addition & 1 deletion public/app/pages/routes.ts
View file
Open in desktop
@@ -1,5 +1,5 @@
export enum ROUTES {
CONTINOUS_SINGLE_VIEW = '/',
SINGLE_VIEW = '/',
COMPARISON_VIEW = '/comparison',
COMPARISON_DIFF_VIEW = '/comparison-diff',
}
Expand Down