This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Add grafana agent docs #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
May 30, 2023
Rperry2174
commented
May 30, 2023
|
|
||
| ## Running the agent | ||
| - `examples/your-application-example/agent/config/config.river` |
There was a problem hiding this comment.
add the actual code here
There was a problem hiding this comment.
How is the Grafana Agent scraping the available containers? Or is it a hardcoded list?
simonswine
approved these changes
Jun 5, 2023
| scheme: http | ||
| profiling_config: | ||
| path_prefix: '/app' | ||
| Create the following directory structure for the example files: |
There was a problem hiding this comment.
Wonder if it is better to describe a git clone instead.
We already have a bit of a demo here: https://github.com/grafana/phlare/tree/main/tools/docker-compose
It is "just" without Grafana Agent
|
|
||
| ## Running the agent | ||
| - `examples/your-application-example/agent/config/config.river` |
There was a problem hiding this comment.
How is the Grafana Agent scraping the available containers? Or is it a hardcoded list?
|
went ahead and merged -- will do another pass on docs here after talking with @rfratto next week and include suggestions @cyriltovena @simonswine |
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Add grafana agent docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding grafana agent docs related grafana/pyroscope#1958