This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
feat(ebpf): move the core ebpf code from agent repo #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Jun 21, 2023
ebpf/go.mod
Outdated
| @@ -0,0 +1,23 @@ | |||
| module github.com/grafana/phlare/ebpf | |||
|
|
|||
| go 1.20 | |||
There was a problem hiding this comment.
Suggested change
| go 1.20 | |
| go 1.19 |
To match the other modules in the repo
There was a problem hiding this comment.
ugh unfortunately a piece of my code does not compile
type Resource interface {
comparable
Refresh()
Cleanup()
}
There was a problem hiding this comment.
I will try to workaround
| type TargetsOptions struct { | ||
| Targets []DiscoveryTarget | ||
| TargetsOnly bool | ||
| DefaultTarget DiscoveryTarget |
There was a problem hiding this comment.
Following up on grafana/agent#3953 (comment), +1 for keeping this while there is not other way to profile the whole system. :)
There was a problem hiding this comment.
+1 for keeping it undocumented until we have other options, let's see what others think
korniltsev
force-pushed
the
korniltsev/ebpf
branch
from
6e36ade
to
57fce5b
Compare
…ed, do not append empty stacktrace to pprof
|
Great work! |
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grafana/agent#3953