This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
Improve Stacktraces Samples Memory Layout #796
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ingest stacktraces in the new symdb * Setup read in memory read path * Fix up a comment placement * Start setting up the read path * Update to uint32 * Introduce stacktrace partition (#775) * Introduce stacktrace partition This determines the partition of a particular profile, by looking first at its metadata: * If there is a `Filename` on the main mapping use its filepath.Base(Filename) * Failing that take the externally supplied `service_name` * Fallback to `unknown` Take the underlying string value and hash. * After a chat with cyril we decided to not longer mod and use the hash straight away. We don't wanted to risk the collisions of two very big stacktrace applications. * Remove reconstructMeta from singleBlockQuerier * support multiple versions of stacktraces resolver * Integrate v2 reader for stacktraces in block reader * Fixes tests * Rewrite locations Ids * Rewrite test for counting uniq stacktraces * lint and fmt * Fixes more tests * Fixes leftover from todo --------- Co-authored-by: Christian Simon <simon@swine.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce a new way to abstract away the memory representation and the file format on disk (parquet). The implementation heavily relies on
parquet.RowReader
it uses this new abstraction to represent stacktraces samples differently.
Instead of using a slice of struct such as :
It uses a double slice :
This highly reduce the amount of memory while ingesting profiles since we use less adress space. On top of that we don't use reflection anymore when flushing Profiles by using a custom parquet serialisation.
This is running in dev and has reduce memory usage by 50%