This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Improve memory layout of locations, functions, and mappings #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Jul 6, 2023
| // case the line information above represents one of the multiple | ||
| // symbols. This field must be recomputed when the symbolization state of the | ||
| // profile changes. | ||
| IsFolded bool |
There was a problem hiding this comment.
struct padding should be improved
There was a problem hiding this comment.
There are two changes comparing to the proto definition:
MappingIdtype uint64 -> uint32;IsFoldedmoved next toMappingId, to avoid extra-padding.
The current type size is 48 bytes, given the 8-bytes alignment. Further improvement seems impossible.
kolesnikovae
force-pushed
the
perf/locations-memory-representation
branch
from
7a15b6f
to
45ff18a
Compare
kolesnikovae
force-pushed
the
perf/locations-memory-representation
branch
from
45ff18a
to
9e5565e
Compare
simonswine
approved these changes
Jul 10, 2023
This was referenced Jul 11, 2023
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 18, 2023
…phlare#814) * Use separate representation for in-memory and parquet * Ensure backward compatibility * Remove unused function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #797
The numbers below is an estimate of the memory consumption reduce:
It is expected that the overall memory consumption of the cluster will be reduced by appx. 20%.