Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Fix makefile issues #816

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix makefile issues #816

merged 2 commits into from
Jul 6, 2023

Conversation

simonswine
Copy link
Collaborator

@simonswine simonswine commented Jul 6, 2023 •
edited

  • Correct environment variables GOOS GOOARCH: Was not setup correctly
  • Give empty second argument: Avoids a warning

@simonswine
Correct environment variables GOOS GOOARCH
abf5262 
The existing version was creating a single env variable GOOS with the
value "linux GOARCH=amd64".
@simonswine
Give empty second argument
a84f3bc
@simonswine simonswine changed the title 20230706 makefiles fixes Fix makefile issues Jul 6, 2023
@simonswine simonswine marked this pull request as ready for review July 6, 2023 10:31
cyriltovena
cyriltovena approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonswine simonswine merged commit 44c6dfc into grafana:main Jul 6, 2023
17 checks passed
simonswine added a commit to simonswine/pyroscope that referenced this pull request Jul 18, 2023
@simonswine
Fix makefile issues (grafana/phlare#816)
321565f 
* Correct environment variables GOOS GOOARCH

The existing version was creating a single env variable GOOS with the
value "linux GOARCH=amd64".

* Give empty second argument
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonswine @cyriltovena