This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Fixes iterator At value re-used #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
commented
Jul 12, 2023
| rows[n] = s.tree.Winner().At() | ||
| rows[n] = rows[n][:0] | ||
| for _, c := range it.At() { | ||
| rows[n] = append(rows[n], c.Clone()) |
There was a problem hiding this comment.
We have to clone each value here since At can change the current row.
|
Well thanks to this PR found another bug :) |
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 18, 2023
* Fixes iterator At value re-used * make fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring a bit how we deal with RowReader but also fixes a bug where we were re-used the
Atof the inner iterator inside the RowReader.Currently causing no grief but did when working on compaction. Already include #842.
Closes #842