This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Fix linting error in frontend #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea what I am doing, but this should fix the linting issue we see on every PR.
darrenjaneczek
approved these changes
Jul 13, 2023
| @@ -14,7 +14,7 @@ import Button from '@webapp/ui/Button'; | |||
| import LoadingSpinner from '@webapp/ui/LoadingSpinner'; | |||
| import DateRangePicker from '@webapp/components/DateRangePicker'; | |||
| import RefreshButton from '@webapp/components/RefreshButton'; | |||
| import AppSelector from '@phlare/components/AppSelector/AppSelector'; | |||
| import { AppSelector } from '@phlare/components/AppSelector/AppSelector'; | |||
There was a problem hiding this comment.
It's funny because both are technically valid.
import { AppSelector } from '@phlare/components/AppSelector/AppSelector';
specifies only importing AppSelector, but since AppSelector is declared as the default export in that module, what was originally there is functionally equivalent.
darrenjaneczek
approved these changes
Jul 13, 2023
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 18, 2023
I have no idea what I am doing, but this should fix the linting issue we see on every PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea what I am doing, but this should fix the linting issue we see on every PR.