This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Use labels API when possible instead of Series #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to finish this and get rid of any old api too |
|
Alright so now we only use connect-go API. (Series, LabelNames and LabelsValues) On top of this we also pass the current query as matchers to correctly reduce values and names for the selected workload. |
cyriltovena
commented
Jul 17, 2023
| }) | ||
| ); | ||
|
|
||
| export async function fetchApps(): Promise< |
There was a problem hiding this comment.
Couldn't find where this is called.
There was a problem hiding this comment.
It's not even loaded.
|
See below it shows only 4 pods of the current app. |
simonswine
approved these changes
Jul 17, 2023
|
I see that that was on auto merge 🙂 Unsure what you mean with the 4 pods? I am able to show more:
|
I meant that before it would show all pods irrespectively of the selection application. |
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 18, 2023
* Use labels API when possible instead of Series * More cleanup * Uses only connect http API. * format * Correctly convert query to labels matcher * Removes todos * Fixes tenants tests * Fixes tenants tests * Fixes tenants tests * Fixes e2e tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series API with
{}query is expensive.