This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
fix/ebpf arm64 unwind #862
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we never had working ebpf profiles in arm64
I found the reason:
old kernels expected x29 register to be 16 byte aligned, however in our go binaries it is 8 bytes aligned.
torvalds/linux@33c222a
In this PR i copied the logic from the kernel unwind logic to the ebpf program itself.
Now it is better
But end of stack is detected imperfectly, also there are bunch of unknowns. Need to debug later more.
before
https://flamegraph.com/share/5a2ad225-240d-11ee-85f3-ba195a7e5c95
after