-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Speed up builds #152
CI: Speed up builds #152
Conversation
… generated/yarn.lock from repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackoverflow.com/a/62244232
Solution 1 says:
you don't need actions/cache@v3
anymore and since you arleady use setup-node
with cache: yarn
you can just yarn --prefer-offline
instead.
So basically:
remove https://github.com/grafana/plugin-tools/pull/152/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR21-R30
and change this line https://github.com/grafana/plugin-tools/pull/152/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR33
to
yarn install --immutable --prefer-offline
Nice! Thanks for the feedback @tolzhabayev I've updated the PR with the suggested changes. |
This part can also go I think? plugin-tools/.github/workflows/ci.yml Lines 21 to 27 in 934365e
|
Turns out you're right. Have removed it. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send 🇮🇹
🚀 PR was released in |
What this PR does / why we need it:
CI builds are slow due to multiple yarn installs happening. This PR addresses this by using the cache action to store the node_modules and generated/node_modules | yarn.lock files to speed up ci.
Also spruces up the readme a bit with badges and grafana logo. 😃
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: