Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling: Use NX instead of Lerna for running tasks #260

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented May 26, 2023

What this PR does / why we need it:
This PR replaces Lerna with NX for task running. The main incentive here is that local development can benefit from caching to prevent running commands with the same input. Lerna will still be required for versioning and publishing the packages in this repo.

If we're happy to merge this I think we could apply for an OSS plan for nx cloud and start using the cache in CI.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@jackw jackw added enhancement New feature or request chore Other changes that don't modify src or test files labels May 26, 2023
@jackw jackw self-assigned this May 26, 2023
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jackw jackw merged commit 7b0a18c into main Jun 1, 2023
4 checks passed
@jackw jackw deleted the jackw/add-nx branch June 1, 2023 10:05
@grafana-delivery-bot
Copy link

🚀 PR was released in @grafana/create-plugin@1.5.2 🚀

@grafana-delivery-bot grafana-delivery-bot bot added the released This issue/pull request has been released. label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files enhancement New feature or request released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants