Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Plugin: fix 'Install dependencies' command in generated frontend README #276

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Create Plugin: fix 'Install dependencies' command in generated frontend README #276

merged 1 commit into from
Jun 6, 2023

Conversation

sd2k
Copy link
Contributor

@sd2k sd2k commented Jun 6, 2023

It should be yarn/npm install, without the 'run' in between.

@sd2k
Fix 'Install dependencies' command in generated frontend README
d62a3c3 
It should be yarn/npm install, without the 'run' in between.
@sd2k sd2k changed the title Fix 'Install dependencies' command in generated frontend README Create Plugin: fix 'Install dependencies' command in generated frontend README Jun 6, 2023
jackw
jackw approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for spotting and fixing this @sd2k ! 🥇

@jackw jackw added type/docs Changes only affect the documentation create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged labels Jun 6, 2023
@sd2k sd2k merged commit 192b75f into main Jun 6, 2023
3 checks passed
@sd2k sd2k deleted the frontend-getting-started-fix-install-command branch June 6, 2023 11:04
@grafana-delivery-bot
Copy link

🚀 PR was released in @grafana/create-plugin@1.6.1 🚀

@grafana-delivery-bot grafana-delivery-bot bot added the released This issue/pull request has been released. label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

Assignees

@sd2k sd2k

Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released. type/docs Changes only affect the documentation
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sd2k @jackw