Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate videos for cypress e2e tests #302

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

academo
Copy link
Member

@academo academo commented Jul 11, 2023

What this PR does / why we need it:

Adds a cypress.json file to the common template to not generate videos when running.

The current (older) version of Cypress is slow in specific scenarios in CI when generating videos.

A effort is in place to migrate to cypress 12 which should bring a solution to the video generation problem

@academo academo added create-plugin related to the create-plugin tool minor Increment the minor version when merged labels Jul 11, 2023
@academo academo requested a review from jackw July 11, 2023 08:29
@academo academo self-assigned this Jul 11, 2023
@jackw jackw added the release Create a release when this pr is merged label Jul 11, 2023
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@academo academo merged commit 9358e0e into main Jul 11, 2023
3 checks passed
@academo academo deleted the academo/disable-e2e-videos branch July 11, 2023 13:56
@grafana-delivery-bot
Copy link

🚀 PR was released in @grafana/create-plugin@1.9.0 🚀

@grafana-delivery-bot grafana-delivery-bot bot added the released This issue/pull request has been released. label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants