Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the scenes-app template to use the latest scenes library and fix some template code style errors #573

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

academo
Copy link
Member

@academo academo commented Dec 8, 2023

What this PR does / why we need it:

Updates the scenes-app library version in the scenes-app template

Fixes using some deprecated methods in the generated code and removing barrel imports

Which issue(s) this PR fixes:

fixes #570

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@2.9.0-canary.573.1b536d6.0
# or 
yarn add @grafana/create-plugin@2.9.0-canary.573.1b536d6.0

@academo academo requested a review from dprokop December 8, 2023 12:41
@academo academo self-assigned this Dec 8, 2023
@academo academo added create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged labels Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@academo academo requested a review from jackw December 8, 2023 14:20
Copy link
Contributor

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great!

@academo academo merged commit affe70d into main Dec 8, 2023
17 of 18 checks passed
@academo academo deleted the academo/update-scenes-app-template branch December 8, 2023 14:22
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@2.9.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

Bug: creating sceneapp generates code with deprecations and warnings
2 participants