-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Doc: Adding a suggestion supplier to a plugin #816
Conversation
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some editorial commits and suggestions, but no blocking issues. LGTM.
|
||
You can add a suggestion supplier to examine query data coming from a panel and suggest usage of the plugin for the type of data detected. This guide provides instructions for doing so along with links to relevant examples. | ||
|
||
A single stat panel would be ranked "high" for a single series, and "low" for multiple series (or even none). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence seems disconnected from what came before. Can you clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add text here, i left out context
|
||
:::note | ||
|
||
When creating a suggestion supplier be certain the plugin can actually render something for the data being provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you don't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grafana will either display a blank panel and/or an error message will be displayed. It's best to offer the plugin only to query data that matches well-known criteria that the author can validate.
|
||
## Additional resources | ||
|
||
Reference these suggestion suppliers to get ideas for further customization: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a sentence or part of a sentence to note what's distinctive about the suggestion suppliers in each of these plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do!
updated with more details, hopefully this reads a little better |
What this PR does / why we need it:
Adds docs for creating a suggestion supplier for a plugin
Which issue(s) this PR fixes:
Fixes # grafana/grafana#84419