Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Added missing nodemon config to plugin-e2e #817

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

mckn
Copy link
Collaborator

@mckn mckn commented Mar 14, 2024

What this PR does / why we need it:
Without the nodemon configuration the plugin-e2e dev script will run in an endless loop since it is triggering on the files bing built by tsc.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@mckn mckn requested a review from a team as a code owner March 14, 2024 09:17
@mckn mckn requested review from leventebalogh and removed request for a team March 14, 2024 09:17
Copy link

github-actions bot commented Mar 14, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

@mckn mckn self-assigned this Mar 14, 2024
@mckn mckn requested a review from sunker March 14, 2024 09:18
@jackw jackw added chore Other changes that don't modify src or test files no-changelog Don't include in changelog and version calculations labels Mar 14, 2024
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mckn mckn merged commit d16b77f into main Mar 15, 2024
16 of 24 checks passed
@mckn mckn deleted the mckn/added-missing-nodemon-config branch March 15, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files no-changelog Don't include in changelog and version calculations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants