Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin: Remove devOnly parameter and related test cases #823

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

oshirohugo
Copy link
Contributor

@oshirohugo oshirohugo commented Mar 14, 2024

What this PR does / why we need it:

Since #707 is merged, keeping the devOnly property in the source doesn't make sense anymore. Therefore we are removing it.

Which issue(s) this PR fixes:

Fixes https://github.com/grafana/grafana-plugins-platform-team/issues/72

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@4.2.4-canary.823.fa85409.0
# or 
yarn add @grafana/create-plugin@4.2.4-canary.823.fa85409.0

@oshirohugo oshirohugo requested a review from a team as a code owner March 14, 2024 15:30
@oshirohugo oshirohugo requested review from academo and removed request for a team March 14, 2024 15:30
@oshirohugo oshirohugo added create-plugin related to the create-plugin tool release Create a release when this pr is merged patch Increment the patch version when merged labels Mar 14, 2024
@oshirohugo oshirohugo self-assigned this Mar 14, 2024
Copy link

github-actions bot commented Mar 14, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@oshirohugo oshirohugo merged commit 9aab0ff into main Mar 18, 2024
16 of 18 checks passed
@oshirohugo oshirohugo deleted the remove-dev-only-parameter branch March 18, 2024 17:13
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@4.2.5 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants