Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition about backend to success message #830

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Ukochka
Copy link
Contributor

@Ukochka Ukochka commented Mar 19, 2024

What this PR does / why we need it:
If created plugin does not have a backend, we do not need to show the message that we need to rerun docker after backend has been changed

Which issue(s) this PR fixes:
Fixes #772

@Ukochka Ukochka added create-plugin related to the create-plugin tool no-changelog Don't include in changelog and version calculations labels Mar 19, 2024
@Ukochka Ukochka self-assigned this Mar 19, 2024
@Ukochka Ukochka requested a review from a team as a code owner March 19, 2024 13:30
@Ukochka Ukochka requested review from jackw and removed request for a team March 19, 2024 13:30
Copy link

github-actions bot commented Mar 19, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged but will not trigger a new release. To trigger a new release add the release label before merging.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@jackw jackw added patch Increment the patch version when merged and removed no-changelog Don't include in changelog and version calculations labels Mar 19, 2024
@Ukochka Ukochka merged commit f99596c into main Mar 19, 2024
16 checks passed
@Ukochka Ukochka deleted the create-plugin-success-message-fix branch March 19, 2024 15:37
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@4.3.0, @grafana/plugin-e2e@0.23.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

nit: create-plugin success message includes backend reference for frontend only plugins
3 participants