Create plugin: Update data source templates #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
commented
Mar 22, 2024
| @@ -79,7 +79,7 @@ export function QueryEditor({ query, onChange, onRunQuery }: Props) { | |||
| const { upperLimit, lowerLimit, tickInterval } = query; | |||
|
|
|||
| return ( | |||
| <div className="gf-form"> | |||
| <> | |||
There was a problem hiding this comment.
Could potentially use the new Box component here, but it does not change appearance so don't think we need it.
sunker
commented
Mar 22, 2024
| applyTemplateVariables(query: MyQuery, scopedVars: ScopedVars): Record<string, any> { | ||
| return { | ||
| ...query, | ||
| queryText: getTemplateSrv().replace(query.queryText, scopedVars), |
There was a problem hiding this comment.
Regarding scoped variables...currently the ds template for plugin.json doesn't specify any query options. Should we skip passing the scopredVars variable to getTemplateSrv().replace?
sunker
commented
Mar 22, 2024
| <div className="gf-form-group"> | ||
| <InlineField label="Path" labelWidth={12}> | ||
| <> | ||
| <InlineField label="Path" labelWidth={14} interactive tooltip={'Json field returned to frontend'}> |
There was a problem hiding this comment.
Re label width: Opened a PR in Grafana to increase the width of the name field to 14. That way we at least give the plugin authors a chance to align field width across the entire page.
sunker
added
major
mckn
approved these changes
Mar 26, 2024
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Was initially going to replace the usage of
gf-classnames in forms, but found some more low hanging fruits in the data source templates that I'm fixing.Which issue(s) this PR fixes:
Fixes #782
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.4.0-canary.836.aa6cb3b.0 npm install @grafana/plugin-e2e@0.24.0-canary.836.aa6cb3b.0 # or yarn add @grafana/create-plugin@4.4.0-canary.836.aa6cb3b.0 yarn add @grafana/plugin-e2e@0.24.0-canary.836.aa6cb3b.0