Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin E2E: Change package imports and exports #838

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Mar 25, 2024

What this PR does / why we need it:

This PR removes a few nested barrel files and replaces all default exports with named exports. Also reorganising some of the package exports, making sure we don't export more types and functions than necessary.

Before this PR, we exported everything under fixtures. With this PR, fixtures are only exposed through the playwright api.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/plugin-e2e@0.24.0-canary.838.72fc2a1.0
# or 
yarn add @grafana/plugin-e2e@0.24.0-canary.838.72fc2a1.0

Copy link

github-actions bot commented Mar 25, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker added minor Increment the minor version when merged release Create a release when this pr is merged labels Mar 25, 2024
@sunker sunker requested a review from jackw March 25, 2024 09:22
@sunker sunker marked this pull request as ready for review March 25, 2024 09:23
@sunker sunker requested a review from a team as a code owner March 25, 2024 09:23
@sunker sunker changed the title Plugin E2E: Restructure package imports and exportrs Plugin E2E: Change package imports and exports Mar 25, 2024
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀

@sunker sunker merged commit 5c85ff1 into main Mar 26, 2024
24 of 26 checks passed
@sunker sunker deleted the plugin-e2e/named-imports branch March 26, 2024 09:06
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/plugin-e2e@0.25.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants