Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Plugin: Fix hardcoded path #846

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Create Plugin: Fix hardcoded path #846

merged 1 commit into from
Mar 28, 2024

Conversation

oshirohugo
Copy link
Contributor

@oshirohugo oshirohugo commented Mar 28, 2024 •
edited by grafana-plugins-platform-bot bot

What this PR does / why we need it:

There is a wrong hardcoded path, pluginId should be used

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@4.4.4-canary.846.e4a64dc.0
# or 
yarn add @grafana/create-plugin@4.4.4-canary.846.e4a64dc.0

@oshirohugo oshirohugo added patch Increment the patch version when merged release Create a release when this pr is merged labels Mar 28, 2024
@oshirohugo oshirohugo self-assigned this Mar 28, 2024
@oshirohugo oshirohugo requested a review from a team as a code owner March 28, 2024 13:52
@oshirohugo oshirohugo requested review from leventebalogh and removed request for a team March 28, 2024 13:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

briangann
briangann approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@oshirohugo oshirohugo merged commit 8fbfac5 into main Mar 28, 2024
15 checks passed
@oshirohugo oshirohugo deleted the fix-hardcoded-path branch March 28, 2024 14:01
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@4.4.4 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangann briangann briangann approved these changes

@leventebalogh leventebalogh Awaiting requested review from leventebalogh leventebalogh is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees

@oshirohugo oshirohugo

Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oshirohugo @briangann