Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Plugin: Scaffold plugins with playwright for e2e #847

Merged
merged 30 commits into from
Apr 5, 2024
Merged

Create Plugin: Scaffold plugins with playwright for e2e #847

merged 30 commits into from
Apr 5, 2024

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Mar 28, 2024 •
edited by grafana-plugins-platform-bot bot

What this PR does / why we need it:

This PR introduces changes required for scaffolding new plugins with plugin-e2e and playwright.

  • On scaffold create-plugin now scaffolds a plugin with playwright configured out the box and sample integration tests.
  • On update create-plugin checks if there is either the usePlaywright feature flag set OR a playwright config file (playwright.config.ts) in the root of the project to decide on which dependencies and scripts should be used.

Tests across various package managers and the github workflow changes can be found in this temporary repo.

Which issue(s) this PR fixes:

Fixes https://github.com/grafana/grafana-plugins-platform-team/issues/106

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@4.5.0-canary.847.62129f3.0
npm install @grafana/plugin-e2e@0.27.0-canary.847.62129f3.0
# or 
yarn add @grafana/create-plugin@4.5.0-canary.847.62129f3.0
yarn add @grafana/plugin-e2e@0.27.0-canary.847.62129f3.0

@jackw jackw added create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged labels Mar 28, 2024
@jackw jackw self-assigned this Mar 28, 2024
@jackw jackw requested a review from a team as a code owner March 28, 2024 14:00
@jackw jackw requested review from mckn and removed request for a team March 28, 2024 14:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@jackw jackw changed the title Create Plugin: Scaffold plugins with playwright for e2e [WIP] Create Plugin: Scaffold plugins with playwright for e2e Mar 28, 2024
sunker
sunker reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @jackw! I'd be happy to contribute to the specs next week.

packages/create-plugin/src/commands/generate.command.ts Outdated Show resolved Hide resolved
packages/create-plugin/templates/common/_package.json Outdated Show resolved Hide resolved
packages/create-plugin/templates/common/playwright.config.ts Outdated Show resolved Hide resolved
packages/create-plugin/templates/github/ci/.github/workflows/ci.yml Show resolved Hide resolved
mckn
mckn reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! ⚡

packages/create-plugin/src/commands/generate.command.ts Outdated Show resolved Hide resolved
packages/create-plugin/templates/common/_package.json Outdated Show resolved Hide resolved
packages/create-plugin/templates/common/tests/smoke.spec.ts Outdated Show resolved Hide resolved
@jackw jackw changed the title [WIP] Create Plugin: Scaffold plugins with playwright for e2e Create Plugin: Scaffold plugins with playwright for e2e Apr 3, 2024
@sunker sunker mentioned this pull request Apr 4, 2024
Merged
leventebalogh
leventebalogh approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! 👏

jackw added 10 commits April 5, 2024 10:59
sunker
sunker approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Awesome work @jackw.

@jackw jackw merged commit 0924544 into main Apr 5, 2024
13 checks passed
@jackw jackw deleted the jackw/create-plugin-plugin-e2e branch April 5, 2024 15:20
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@4.6.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckn mckn mckn left review comments

@tolzhabayev tolzhabayev tolzhabayev left review comments

@sympatheticmoose sympatheticmoose sympatheticmoose left review comments

@sunker sunker sunker approved these changes

@leventebalogh leventebalogh leventebalogh approved these changes

Assignees

@jackw jackw

Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jackw @mckn @tolzhabayev @sunker @leventebalogh @sympatheticmoose