Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Plugins: Add feature to toggle docker development environment #857

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Create Plugins: Add feature to toggle docker development environment #857

merged 1 commit into from
Apr 5, 2024

Conversation

oshirohugo
Copy link
Contributor

What this PR does / why we need it:

This adds the possibility to toggle the docker development environment on/off.

Which issue(s) this PR fixes:

Closes #851

Special notes for your reviewer:

@oshirohugo oshirohugo added create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged labels Apr 4, 2024
@oshirohugo oshirohugo self-assigned this Apr 4, 2024
@oshirohugo oshirohugo requested a review from a team as a code owner April 4, 2024 09:45
@oshirohugo oshirohugo requested review from Ukochka and removed request for a team April 4, 2024 09:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

briangann
briangann approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, more alternatives for debugging!

@oshirohugo oshirohugo merged commit 4076a8c into main Apr 5, 2024
15 checks passed
@oshirohugo oshirohugo deleted the add-development-flag-to-docker-environment branch April 5, 2024 08:59
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@4.5.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangann briangann briangann approved these changes

@Ukochka Ukochka Awaiting requested review from Ukochka Ukochka is a code owner automatically assigned from grafana/plugins-platform-frontend

@jackw jackw Awaiting requested review from jackw

@leventebalogh leventebalogh Awaiting requested review from leventebalogh

Assignees

@oshirohugo oshirohugo

Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Add option for development and test enviroment
2 participants
@oshirohugo @briangann