Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check compatibility with min version #863

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sympatheticmoose
Copy link
Contributor

This is just an idea and not verified whether it actually works or not, especially substituting the version within the levitate call.

Its very brittle based on how people could use this field, but may serve as a way to check against whether recent changes break older compatibility.

Copy link

github-actions bot commented Apr 8, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

❌ This PR cannot be merged until the following issues are addressed:

  • This PR is missing one of the following labels: patch, minor, major, no-changelog.
  • Optionally if using a patch, minor or major label also add the release label if you would like this PR to trigger npm package publishing.
🏷️ More info about which labels to use
  • If the changes only affect the docs website, documentation, or this repository's tooling add the no-changelog label.
  • If there are changes to any of the npm packages src files please choose from one of the following labels:
    • 🐛 if this PR fixes a bug add the patch label
    • 🚀 if this PR includes an enhancement add the minor label
    • 💥 if this PR includes a breaking change add the major label
  • Optionally, if you would like this PR to publish new versions of packages when it is merged add the release label.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sympatheticmoose
Copy link
Contributor Author

note to self: missing jq -r '.dependencies.grafanaDependency'

Also copying over from slack w @leventebalogh

I think instead of bash maybe we could use javascript in the step's script, and then we could probably more easily parse the semver string (if it's a semver string) to get the min and max versions?
That way we could we could tell if the plugin is compatible with the provided grafana dependency range.
(Latest is maybe outside of that range - however it can still be a useful information if it would break with latest)

@sympatheticmoose sympatheticmoose self-assigned this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧑‍💻 In development
Development

Successfully merging this pull request may close these issues.

None yet

2 participants